[dev-v5] Enhance TextInput component #4450
Merged
+55
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame change in v5 - Add Color, Search and Number to the TextInputType enum - Add example for using the TextInputTypes
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the TextInput component by renaming the property from TextFieldType to TextInputType to align with v5 naming conventions, and adds support for three new input types (Color, Search, and Number). The changes include proper documentation indicating that implementation relies on browser support and may vary between browsers.
Key Changes
- Property renamed from
TextFieldTypetoTextInputTypefor consistency with the component name - Added Color, Search, and Number types to the
TextInputTypeenum - Added comprehensive example demonstrating all input types with browser support note in documentation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Core/Enums/TextInputType.cs |
Added three new enum values (Color, Search, Number) with appropriate descriptions |
src/Core/Components/TextInput/FluentTextInput.razor.cs |
Renamed property from TextFieldType to TextInputType and added browser support note to XML documentation |
src/Core/Components/TextInput/FluentTextInput.razor |
Updated property reference from TextFieldType to TextInputType |
src/Core/Components/DataGrid/Columns/ColumnResizeOptions.razor |
Removed redundant TextFieldType property specification |
examples/Demo/FluentUI.Demo.Client/Documentation/Components/TextInput/FluentTextInput.md |
Added documentation section for TextInput types with browser support note |
examples/Demo/FluentUI.Demo.Client/Documentation/Components/TextInput/Examples/TextInputTypes.razor |
New example file demonstrating all TextInputType options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...s/Demo/FluentUI.Demo.Client/Documentation/Components/TextInput/Examples/TextInputTypes.razor
Show resolved
Hide resolved
...s/Demo/FluentUI.Demo.Client/Documentation/Components/TextInput/Examples/TextInputTypes.razor
Outdated
Show resolved
Hide resolved
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.7%
|
dvoituron
requested changes
Jan 8, 2026
examples/Demo/FluentUI.Demo.Client/Documentation/Components/TextInput/FluentTextInput.md
Show resolved
Hide resolved
dvoituron
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes related to the TextInput component: