Skip to content

Potential fix for code scanning alert no. 3: Prototype-polluting assignment #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rurikoaraki merged 3 commits into from
Jan 29, 2025
Merged

Potential fix for code scanning alert no. 3: Prototype-polluting assignment #3845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aed8960
Potential fix for code scanning alert no. 3: Prototype-polluting assi…
rurikoaraki Jan 28, 2025
e9f429c
Change files
rurikoaraki Jan 28, 2025
30962de
Fix build issue
rurikoaraki Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-native-memo-cache-0c1ce6d7-722e-4518-9cf5-bc2fe0e0ced9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Potential fix for code scanning alert no. 3: Prototype-polluting assignment",
"packageName": "@fluentui-react-native/memo-cache",
"email": "[email protected]",
"dependentChangeType": "patch"
}
3 changes: 3 additions & 0 deletions packages/framework/memo-cache/src/getCacheEntry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ export type CacheEntry<T, TGet = any> = {
* @param key - which key of that entry to ensure the value for
*/
function ensureAndReturn(entry: CacheEntry<any>, key: keyof CacheEntry<any>): CacheEntry<any> | { [key: string]: CacheEntry<any> } {
if ((key as string) === '__proto__' || (key as string) === 'constructor' || (key as string) === 'prototype') {
throw new Error('Invalid key');
}
return (entry[key] = entry[key] || {});
}

Expand Down