Skip to content

Fix peer dep warnings when running yarn #3904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rurikoaraki merged 3 commits into from
Jun 16, 2025
Merged

Fix peer dep warnings when running yarn #3904

rurikoaraki merged 3 commits into from
Jun 16, 2025

Conversation

@rurikoaraki
Copy link
Collaborator

@rurikoaraki rurikoaraki commented Jun 16, 2025 •
edited
Loading

Fixing the last peer dep warnings that appear when running yarn:

  • Update version of use-subscription
  • Change our react-dom version to 18.2.0 to align with react version of RN. We do this via yarn.lock so that we can look into changing the depdencies of FURN to allow multiple RN versions, at which point we couldnt restrict react that tightly

@rurikoaraki rurikoaraki requested a review from a team as a code owner June 16, 2025 18:10
@rurikoaraki rurikoaraki changed the title Bump our version of use-subscription Fix peer dep warnings when running yarn Jun 16, 2025
@Saadnajmi
Copy link
Collaborator

Saadnajmi commented Jun 16, 2025

Congrats!

@rurikoaraki rurikoaraki merged commit 6cf2ef4 into microsoft:main Jun 16, 2025
11 checks passed
@rurikoaraki rurikoaraki deleted the user/ruaraki/fix_usesubscription_yarn branch June 16, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rurikoaraki @Saadnajmi