MenuButton Narrator A11y Bug Fix #3920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurikoaraki
reviewed
Jun 25, 2025
rurikoaraki
approved these changes
Jun 25, 2025
rurikoaraki
approved these changes
Jun 25, 2025
rurikoaraki
approved these changes
Jun 26, 2025
Dewsk
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Narrator wasn't announcing a description indicative of a MenuButton being able to toggle. We fixed this by setting the expand/collapse state. Now, Narrator announces if the menu is expanded or collapsed.
Verification
Manually verified that Narrator is announcing the expand/collapse state in the FURN tester.
Pull request checklist
This PR has considered (when applicable):