Skip to content

Fix build error by exporting a missing type from the framework package #3922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JasonVMo merged 2 commits into from
Jul 2, 2025
Merged

Fix build error by exporting a missing type from the framework package #3922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b3ce95
export missing type from framework package
JasonVMo Jul 2, 2025
2e76bc1
Change files
JasonVMo Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-native-framework-aafca808-a718-4bae-aa2e-92db63b904dd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "export missing type from framework to fix build error in Popover",
"packageName": "@fluentui-react-native/framework",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/framework/framework/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,4 @@ export type { HasLayer, TokensThatAreAlsoProps, UseStyling } from './useStyling'
export { buildProps, buildUseStyling } from './useStyling';
export type { BuildProps, TokenSettings, TokensFromTheme, UseStylingOptions } from './useStyling';
export { applyPropsToTokens, applyTokenLayers, buildUseTokens, customizable, patchTokens } from './useTokens';
export type { UseTokens } from './useTokens';
export type { UseTokens, CustomizableComponent } from './useTokens';
1 change: 1 addition & 0 deletions packages/framework/framework/src/useTokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export { applyTokenLayers, applyPropsToTokens, customizable, patchTokens } from

// A hook function to build a set of tokens from a passed in theme as well as a cache object
export type UseTokens<TTokens> = UseTokensCore<TTokens, Theme>;
export type { CustomizableComponent } from '@fluentui-react-native/use-tokens';

export function buildUseTokens<TTokens>(...tokens: TokenSettings<TTokens>[]): UseTokens<TTokens> {
return buildUseTokensCore(themeHelper.getComponentInfo, ...tokens);
Expand Down