-
Notifications
You must be signed in to change notification settings - Fork 170
Rework scripts to no longer require the build-tools step, and make eventual direct TS transition easier #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…based of rnx-kit's node tsconfig
Collaborator
|
Do we still need the lage step "build-tools"? |
Contributor
Author
Good catch. I had it in another version of it but forgot to do it this time. Updated with paring down of the lage config (and fixing the execution of prettier in the scripts folder). |
Saadnajmi
approved these changes
Jul 14, 2025
Saadnajmi
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
While it is possible to run TS directly in node 22.x, it isn't 100% viable until 23.6 because it is too easy to loop back into scripts and inadvertently call without the extra command line args. At the same time the build-tools step is super tedious when changing engineering systems stuff so I want the ability to execute it directly. Finally the scripts directory was a mess. This PR makes the following changes:
Ultimately many of the files that look brand new are actually renames from .ts to .js which are showing up as moves. Most of the changes are changing require to import statements, and changing config references.