Skip to content

FIx double onClick when invoking buttons via keyboard in Windows #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rurikoaraki merged 2 commits into from
Nov 5, 2025
+8 −1
Merged

FIx double onClick when invoking buttons via keyboard in Windows #3970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f2bca7
Update shouldOnlyFireIfPressed for Windows platforms
sprx97 Nov 4, 2025
1187d52
Change files
sprx97 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-native-button-05775eef-ba52-4258-b089-a2c1351a8382.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update shouldOnlyFireIfPressed for Windows platforms",
"packageName": "@fluentui-react-native/button",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/components/Button/src/useButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import type { ButtonProps, ButtonInfo } from './Button.types';
// like the button firing after you tab to it white Enter is pressed
// and then releasing Enter, or the Menu reopening since it closes
// onKeyDown while the Button operates onKeyUp.
const shouldOnlyFireIfPressed = Platform.OS === ('win32' as any);
const shouldOnlyFireIfPressed = Platform.OS === ('win32' as any) || Platform.OS === ('windows' as any);
let isProcessingKeyboardInvocation = false;

export const useButton = (props: ButtonProps): ButtonInfo => {
Expand Down