Skip to content

Comments

feat: nested FlatTree support#29036

Closed
bsunderhus wants to merge 1 commit intomicrosoft:masterfrom
bsunderhus:react-tree/feat--nested-flat-tree
Closed

feat: nested FlatTree support#29036
bsunderhus wants to merge 1 commit intomicrosoft:masterfrom
bsunderhus:react-tree/feat--nested-flat-tree

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Aug 31, 2023

Previous Behavior

New Behavior

  1. adds support for the creation of nested flat trees

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Aug 31, 2023
@github-actions github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 31, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 11 11 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 623 593 5000
Button mount 323 324 5000
Field mount 1114 1127 5000
FluentProvider mount 695 670 5000
FluentProviderWithTheme mount 88 82 10
FluentProviderWithTheme virtual-rerender 75 71 10
FluentProviderWithTheme virtual-rerender-with-unmount 78 73 10
InfoButton mount 11 11 5000 Possible regression
MakeStyles mount 822 872 50000
Persona mount 1728 1727 5000
SpinButton mount 1354 1369 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 31, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 03aaa3f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2023

📊 Bundle size report

🤖 This report was generated against 8582884f9000d15185fe7b074c6fde00d84e961c

@bsunderhus bsunderhus force-pushed the react-tree/feat--nested-flat-tree branch from fe8dea2 to 85b8cbb Compare August 31, 2023 12:33
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Aug 31, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3967e12bed4a283fa45591dd6cc731bf2d3230b5 (build)

@bsunderhus bsunderhus force-pushed the react-tree/feat--nested-flat-tree branch 4 times, most recently from ea68397 to e483939 Compare September 1, 2023 11:50
@bsunderhus bsunderhus force-pushed the react-tree/feat--nested-flat-tree branch from 03aaa3f to b7b3bfc Compare September 6, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants