Skip to content

Comments

bugfix: fix missing types on import source#29092

Merged
bsunderhus merged 1 commit intomicrosoft:masterfrom
bsunderhus:react-jsx-runtime/bugfix--fix-missing-types
Sep 7, 2023
Merged

bugfix: fix missing types on import source#29092
bsunderhus merged 1 commit intomicrosoft:masterfrom
bsunderhus:react-jsx-runtime/bugfix--fix-missing-types

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Sep 7, 2023

New Behavior

  1. updates just build to include .d.ts files in the dist folder

Related Issue(s)

@bsunderhus bsunderhus self-assigned this Sep 7, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 7, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 625 612 5000
Button mount 322 323 5000
Field mount 1110 1131 5000
FluentProvider mount 687 688 5000
FluentProviderWithTheme mount 79 85 10
FluentProviderWithTheme virtual-rerender 70 74 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 78 10
InfoButton mount 10 12 5000
MakeStyles mount 863 872 50000
Persona mount 1719 1718 5000
SpinButton mount 1400 1294 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 697dccf:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 7, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
91.384 kB
27.926 kB
react-alert
Alert
84.549 kB
23.128 kB
react-avatar
Avatar
49.738 kB
15.631 kB
react-avatar
AvatarGroup
18.584 kB
7.448 kB
react-avatar
AvatarGroupItem
64.39 kB
19.977 kB
react-badge
Badge
25.793 kB
8.348 kB
react-badge
CounterBadge
26.694 kB
8.658 kB
react-badge
PresenceBadge
24.75 kB
8.96 kB
react-button
Button
39.658 kB
10.79 kB
react-button
CompoundButton
47.013 kB
12.284 kB
react-button
MenuButton
44.085 kB
12.041 kB
react-button
SplitButton
52.111 kB
13.612 kB
react-button
ToggleButton
56.746 kB
12.698 kB
react-card
Card - All
91.249 kB
26.409 kB
react-card
Card
86.038 kB
24.868 kB
react-card
CardFooter
11.951 kB
5.031 kB
react-card
CardHeader
14.237 kB
5.798 kB
react-card
CardPreview
12.903 kB
5.408 kB
react-checkbox
Checkbox
35.614 kB
11.771 kB
react-combobox
Combobox (including child components)
90.383 kB
29.52 kB
react-combobox
Dropdown (including child components)
88.738 kB
29.167 kB
react-components
react-components: Button, FluentProvider & webLightTheme
69.517 kB
19.64 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.327 kB
59.386 kB
react-components
react-components: FluentProvider & webLightTheme
40.713 kB
13.509 kB
react-datepicker-compat
DatePicker Compat
211.433 kB
58.785 kB
react-dialog
Dialog (including children components)
89.917 kB
27.447 kB
react-divider
Divider
19.704 kB
7.38 kB
react-field
Field
21.036 kB
8.091 kB
react-image
Image
14.62 kB
5.869 kB
react-infobutton
InfoButton
129.444 kB
40.699 kB
react-infobutton
InfoLabel
133.169 kB
41.891 kB
react-input
Input
25.955 kB
8.81 kB
react-jsx-runtime
Classic Pragma
1.072 kB
544 B
react-jsx-runtime
JSX Dev Runtime
2.775 kB
1.29 kB
react-jsx-runtime
JSX Runtime
3.293 kB
1.529 kB
react-label
Label
13.036 kB
5.405 kB
react-link
Link
15.902 kB
6.506 kB
react-menu
Menu (including children components)
139.629 kB
43.01 kB
react-menu
Menu (including selectable components)
142.365 kB
43.541 kB
react-persona
Persona
56.629 kB
17.505 kB
react-popover
Popover
118.698 kB
37.359 kB
react-portal-compat
PortalCompatProvider
6.541 kB
2.227 kB
react-progress
ProgressBar
16.409 kB
6.58 kB
react-provider
FluentProvider
21.258 kB
7.937 kB
react-radio
Radio
29.318 kB
9.699 kB
react-radio
RadioGroup
14.344 kB
5.942 kB
react-select
Select
27.324 kB
9.773 kB
react-slider
Slider
36.849 kB
12.171 kB
react-spinbutton
SpinButton
35.53 kB
11.367 kB
react-spinner
Spinner
22.292 kB
8.113 kB
react-switch
Switch
31.885 kB
10.356 kB
react-table
DataGrid
156.416 kB
43.567 kB
react-table
Table (Primitives only)
42.463 kB
13.255 kB
react-table
Table as DataGrid
129.276 kB
34.739 kB
react-table
Table (Selection only)
74.56 kB
20.053 kB
react-table
Table (Sort only)
73.191 kB
19.649 kB
react-tags-preview
InteractionTag
13.85 kB
5.626 kB
react-tags-preview
Tag
29.604 kB
9.567 kB
react-tags-preview
TagGroup
72.493 kB
21.628 kB
react-text
Text - Default
15.644 kB
6.223 kB
react-text
Text - Wrappers
18.817 kB
6.546 kB
react-textarea
Textarea
30.005 kB
10.156 kB
react-toast
Toast (including Toaster)
91.601 kB
27.394 kB
react-tooltip
Tooltip
51.154 kB
18.06 kB
🤖 This report was generated against 8caa21adcd6e67626032e5d0a5dee81f83bde419

@size-auditor
Copy link

size-auditor bot commented Sep 7, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8caa21adcd6e67626032e5d0a5dee81f83bde419 (build)

@bsunderhus bsunderhus marked this pull request as ready for review September 7, 2023 09:06
@bsunderhus bsunderhus requested a review from a team as a code owner September 7, 2023 09:06
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 7, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus force-pushed the react-jsx-runtime/bugfix--fix-missing-types branch from c1c6a38 to 697dccf Compare September 7, 2023 09:31
@bsunderhus bsunderhus requested a review from a team as a code owner September 7, 2023 09:31
@bsunderhus bsunderhus merged commit cbcc41c into microsoft:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: react-jsx-runtime@9.0.5 missing some types (.d.ts) files

4 participants