Skip to content

Comments

feat: create FlatTreeItem component#29098

Merged
bsunderhus merged 1 commit intomicrosoft:masterfrom
bsunderhus:react-tree/feat--create-FlatTreeItem-component
Sep 20, 2023
Merged

feat: create FlatTreeItem component#29098
bsunderhus merged 1 commit intomicrosoft:masterfrom
bsunderhus:react-tree/feat--create-FlatTreeItem-component

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Sep 7, 2023

Previous Behavior

New Behavior

  1. adds FlatTreeItem component
  2. updates flat tree stories to use FlatTreeItem

@bsunderhus bsunderhus self-assigned this Sep 7, 2023
@bsunderhus bsunderhus marked this pull request as ready for review September 7, 2023 15:39
@bsunderhus bsunderhus requested review from a team as code owners September 7, 2023 15:39
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 13 13 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 607 618 5000
Button mount 310 309 5000
Field mount 1108 1146 5000
FluentProvider mount 697 709 5000
FluentProviderWithTheme mount 75 76 10
FluentProviderWithTheme virtual-rerender 74 59 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 69 10
InfoButton mount 13 13 5000 Possible regression
MakeStyles mount 867 849 50000
Persona mount 1765 1720 5000
SpinButton mount 1363 1343 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2f12533:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.517 kB
19.64 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.327 kB
59.386 kB
react-components
react-components: FluentProvider & webLightTheme
40.713 kB
13.509 kB
react-portal-compat
PortalCompatProvider
6.541 kB
2.227 kB
🤖 This report was generated against cbcc41cab55eb19e12faf363d0c96adb45ee2cb0

@size-auditor
Copy link

size-auditor bot commented Sep 7, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cbcc41cab55eb19e12faf363d0c96adb45ee2cb0 (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus merged commit 97568b1 into microsoft:master Sep 20, 2023
@bsunderhus bsunderhus deleted the react-tree/feat--create-FlatTreeItem-component branch September 20, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants