Skip to content

Comments

breaking-change(react-accordion): removes deprecated method from accordion item context#29159

Closed
bsunderhus wants to merge 1 commit intomicrosoft:masterfrom
bsunderhus:react-accordion/breaking-change--removes-deprecated-method-from-accordion-item-context
Closed

breaking-change(react-accordion): removes deprecated method from accordion item context#29159
bsunderhus wants to merge 1 commit intomicrosoft:masterfrom
bsunderhus:react-accordion/breaking-change--removes-deprecated-method-from-accordion-item-context

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Sep 18, 2023

⚠️⚠️ BREAKING CHANGE ⚠️⚠️

  1. removes deprecated method onHeaderClick from accordion item context
  2. bumps the minor version, as it's a breaking change

The method was marked as deprecated and it's not used internally. The decision to remove it is due to possible memory retaining issues reported by clients.

@bsunderhus bsunderhus self-assigned this Sep 18, 2023
@bsunderhus bsunderhus force-pushed the react-accordion/breaking-change--removes-deprecated-method-from-accordion-item-context branch from 3584b6c to 4743edd Compare September 18, 2023 09:18
@bsunderhus bsunderhus marked this pull request as ready for review September 18, 2023 09:25
@bsunderhus bsunderhus requested a review from a team as a code owner September 18, 2023 09:25
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 18, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
91.384 kB
27.926 kB
91.255 kB
27.894 kB
-129 B
-32 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.141 kB
59.349 kB
208.012 kB
59.316 kB
-129 B
-33 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.328 kB
19.608 kB
react-components
react-components: FluentProvider & webLightTheme
40.713 kB
13.509 kB
react-portal-compat
PortalCompatProvider
6.541 kB
2.227 kB
🤖 This report was generated against b1aa5b69df488291671c7bac8134f8a3a785c3e8

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f7f159d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b1aa5b69df488291671c7bac8134f8a3a785c3e8 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 18, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus marked this pull request as draft September 18, 2023 15:56
@bsunderhus bsunderhus force-pushed the react-accordion/breaking-change--removes-deprecated-method-from-accordion-item-context branch from 4743edd to f7f159d Compare September 19, 2023 13:20
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 601 626 5000
Button mount 304 316 5000
Field mount 1106 1095 5000
FluentProvider mount 686 705 5000
FluentProviderWithTheme mount 81 84 10
FluentProviderWithTheme virtual-rerender 79 73 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 83 10
InfoButton mount 8 11 5000
MakeStyles mount 863 866 50000
Persona mount 1796 1684 5000
SpinButton mount 1368 1374 5000

@bsunderhus
Copy link
Contributor Author

Closing this in favor of properly fixing this on SWC side, see swc-project/swc#7977 for more details

@bsunderhus bsunderhus closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants