Skip to content

Comments

feat: Individual columns should be sortable#29196

Merged
ling1726 merged 31 commits intomicrosoft:masterfrom
ling1726:grid-sortable
Sep 21, 2023
Merged

feat: Individual columns should be sortable#29196
ling1726 merged 31 commits intomicrosoft:masterfrom
ling1726:grid-sortable

Conversation

@ling1726
Copy link
Contributor

@ling1726 ling1726 commented Sep 20, 2023

Carry on of @kkakroo's work in #28633

DataGrid

The sortable prop still needs to be set on the DataGrid component to enable sort features. However, any column definitions without a valid compare function will not have a sortable column

Table

TableHeaderCell now supports a sortable prop that can override the same prop on the parent Table

Fixes #28511

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 20, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 80 72 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 628 600 5000
Button mount 319 305 5000
Field mount 1128 1108 5000
FluentProvider mount 701 674 5000
FluentProviderWithTheme mount 72 72 10
FluentProviderWithTheme virtual-rerender 62 57 10
FluentProviderWithTheme virtual-rerender-with-unmount 80 72 10 Possible regression
InfoButton mount 13 11 5000
MakeStyles mount 864 854 50000
Persona mount 1723 1726 5000
SpinButton mount 1364 1374 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 20, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-table
DataGrid
156.606 kB
43.603 kB
156.732 kB
43.665 kB
126 B
62 B
react-table
Table (Primitives only)
42.651 kB
13.28 kB
42.668 kB
13.304 kB
17 B
24 B
react-table
Table as DataGrid
129.472 kB
34.761 kB
129.489 kB
34.797 kB
17 B
36 B
react-table
Table (Selection only)
74.748 kB
20.076 kB
74.765 kB
20.107 kB
17 B
31 B
react-table
Table (Sort only)
73.379 kB
19.672 kB
73.396 kB
19.701 kB
17 B
29 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.572 kB
19.658 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.392 kB
59.385 kB
react-components
react-components: FluentProvider & webLightTheme
40.966 kB
13.569 kB
react-portal-compat
PortalCompatProvider
6.541 kB
2.227 kB
🤖 This report was generated against 81d629fbc7206dab2bc2dd4878487a079601f396

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 20, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f34031e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 20, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 81d629fbc7206dab2bc2dd4878487a079601f396 (build)

@ling1726 ling1726 marked this pull request as ready for review September 21, 2023 09:49
@ling1726 ling1726 requested a review from a team as a code owner September 21, 2023 09:49
@ling1726 ling1726 changed the title Grid sortable feat: Individual columns should be sortable Sep 21, 2023
@ling1726 ling1726 merged commit f6a23fb into microsoft:master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: DataGrid v9 - ability to set sortable property on individual columns

4 participants