bugfix(react-jsx-runtime): react dev runtime call is missing source parameter by bsunderhus · Pull Request #29295 · microsoft/fluentui

bsunderhus · 2023-09-26T10:17:17Z

Previous Behavior

PR #29162 forgets to provide source and self parameters to the actual react runtime invocation

fluentui/packages/react-components/react-jsx-runtime/src/jsx/createJSX.ts

Line 24 in 031ecaf

return runtime(type, overrideProps, key);

This is not a problem in production, as those 2 parameters are only available in development, but missing them in development will cause erroneous error messages regarding static vs dynamic runtime.

New Behavior

provides source and self parameters to the react runtime.

Related Issue(s)

Fixes #

fabricteam · 2023-09-26T10:27:46Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	633	630	5000
Button	mount	305	312	5000
Field	mount	1124	1156	5000
FluentProvider	mount	697	695	5000
FluentProviderWithTheme	mount	75	89	10
FluentProviderWithTheme	virtual-rerender	66	59	10
FluentProviderWithTheme	virtual-rerender-with-unmount	77	74	10
InfoButton	mount	11	8	5000
MakeStyles	mount	863	846	50000
Persona	mount	1749	1752	5000
SpinButton	mount	1416	1341	5000

codesandbox-ci · 2023-09-26T10:30:05Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 70c7b39:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-09-26T10:32:37Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react-accordion` Accordion (including children components)	`91.68 kB` `28.007 kB`	`91.684 kB` `28.007 kB`	`4 B`
`react-alert` Alert	`83.653 kB` `22.915 kB`	`83.657 kB` `22.915 kB`	`4 B`
`react-avatar` Avatar	`49.181 kB` `15.491 kB`	`49.185 kB` `15.491 kB`	`4 B`
`react-avatar` AvatarGroup	`18.712 kB` `7.458 kB`	`18.716 kB` `7.458 kB`	`4 B`
`react-avatar` AvatarGroupItem	`63.837 kB` `19.834 kB`	`63.841 kB` `19.834 kB`	`4 B`
`react-badge` Badge	`25.917 kB` `8.355 kB`	`25.921 kB` `8.354 kB`	`4 B` `-1 B`
`react-badge` CounterBadge	`26.818 kB` `8.658 kB`	`26.822 kB` `8.657 kB`	`4 B` `-1 B`
`react-badge` PresenceBadge	`24.323 kB` `8.867 kB`	`24.327 kB` `8.867 kB`	`4 B`
`react-button` Button	`39.44 kB` `10.738 kB`	`39.444 kB` `10.738 kB`	`4 B`
`react-button` CompoundButton	`46.795 kB` `12.233 kB`	`46.799 kB` `12.233 kB`	`4 B`
`react-button` MenuButton	`44.214 kB` `12.119 kB`	`44.218 kB` `12.12 kB`	`4 B` `1 B`
`react-button` SplitButton	`52.228 kB` `13.705 kB`	`52.232 kB` `13.705 kB`	`4 B`
`react-button` ToggleButton	`56.486 kB` `12.641 kB`	`56.49 kB` `12.641 kB`	`4 B`
`react-card` Card - All	`91.48 kB` `26.485 kB`	`91.484 kB` `26.485 kB`	`4 B`
`react-card` Card	`86.306 kB` `24.947 kB`	`86.31 kB` `24.946 kB`	`4 B` `-1 B`
`react-card` CardFooter	`12.07 kB` `5.034 kB`	`12.074 kB` `5.034 kB`	`4 B`
`react-card` CardHeader	`14.319 kB` `5.8 kB`	`14.323 kB` `5.8 kB`	`4 B`
`react-card` CardPreview	`13.027 kB` `5.403 kB`	`13.031 kB` `5.404 kB`	`4 B` `1 B`
`react-checkbox` Checkbox	`35.955 kB` `11.852 kB`	`35.959 kB` `11.852 kB`	`4 B`
`react-combobox` Combobox (including child components)	`90.117 kB` `29.441 kB`	`90.121 kB` `29.441 kB`	`4 B`
`react-combobox` Dropdown (including child components)	`88.557 kB` `29.081 kB`	`88.561 kB` `29.081 kB`	`4 B`
`react-components` react-components: Button, FluentProvider & webLightTheme	`69.223 kB` `19.584 kB`	`69.227 kB` `19.584 kB`	`4 B`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`206.779 kB` `59.084 kB`	`206.783 kB` `59.084 kB`	`4 B`
`react-components` react-components: FluentProvider & webLightTheme	`40.789 kB` `13.521 kB`	`40.793 kB` `13.521 kB`	`4 B`
`react-datepicker-compat` DatePicker Compat	`210.553 kB` `58.665 kB`	`210.557 kB` `58.665 kB`	`4 B`
`react-dialog` Dialog (including children components)	`88.303 kB` `26.334 kB`	`88.307 kB` `26.334 kB`	`4 B`
`react-divider` Divider	`19.832 kB` `7.391 kB`	`19.836 kB` `7.392 kB`	`4 B` `1 B`
`react-field` Field	`21.439 kB` `8.194 kB`	`21.443 kB` `8.194 kB`	`4 B`
`react-image` Image	`14.748 kB` `5.874 kB`	`14.752 kB` `5.875 kB`	`4 B` `1 B`
`react-infobutton` InfoButton	`128.84 kB` `40.576 kB`	`128.844 kB` `40.576 kB`	`4 B`
`react-infobutton` InfoLabel	`132.531 kB` `41.752 kB`	`132.535 kB` `41.752 kB`	`4 B`
`react-input` Input	`25.966 kB` `8.771 kB`	`25.97 kB` `8.77 kB`	`4 B` `-1 B`
`react-jsx-runtime` JSX Dev Runtime	`2.87 kB` `1.307 kB`	`2.874 kB` `1.307 kB`	`4 B`
`react-jsx-runtime` JSX Runtime	`3.456 kB` `1.542 kB`	`3.46 kB` `1.542 kB`	`4 B`
`react-label` Label	`13.155 kB` `5.416 kB`	`13.159 kB` `5.416 kB`	`4 B`
`react-link` Link	`15.979 kB` `6.493 kB`	`15.983 kB` `6.492 kB`	`4 B` `-1 B`
`react-menu` Menu (including children components)	`138.751 kB` `42.859 kB`	`138.755 kB` `42.859 kB`	`4 B`
`react-menu` Menu (including selectable components)	`141.437 kB` `43.369 kB`	`141.441 kB` `43.369 kB`	`4 B`
`react-persona` Persona	`56.072 kB` `17.369 kB`	`56.076 kB` `17.369 kB`	`4 B`
`react-popover` Popover	`117.585 kB` `37.1 kB`	`117.589 kB` `37.101 kB`	`4 B` `1 B`
`react-progress` ProgressBar	`16.444 kB` `6.546 kB`	`16.448 kB` `6.545 kB`	`4 B` `-1 B`
`react-provider` FluentProvider	`21.334 kB` `7.945 kB`	`21.338 kB` `7.945 kB`	`4 B`
`react-radio` Radio	`29.716 kB` `9.801 kB`	`29.72 kB` `9.802 kB`	`4 B` `1 B`
`react-radio` RadioGroup	`14.351 kB` `5.913 kB`	`14.355 kB` `5.913 kB`	`4 B`
`react-select` Select	`27.688 kB` `9.85 kB`	`27.692 kB` `9.849 kB`	`4 B` `-1 B`
`react-slider` Slider	`36.866 kB` `12.142 kB`	`36.87 kB` `12.141 kB`	`4 B` `-1 B`
`react-spinbutton` SpinButton	`35.853 kB` `11.427 kB`	`35.857 kB` `11.426 kB`	`4 B` `-1 B`
`react-spinner` Spinner	`22.408 kB` `8.118 kB`	`22.412 kB` `8.118 kB`	`4 B`
`react-switch` Switch	`32.175 kB` `10.437 kB`	`32.179 kB` `10.437 kB`	`4 B`
`react-table` DataGrid	`155.916 kB` `43.462 kB`	`155.92 kB` `43.463 kB`	`4 B` `1 B`
`react-table` Table (Primitives only)	`42.711 kB` `13.341 kB`	`42.715 kB` `13.341 kB`	`4 B`
`react-table` Table as DataGrid	`129.186 kB` `34.771 kB`	`129.19 kB` `34.771 kB`	`4 B`
`react-table` Table (Selection only)	`74.553 kB` `20.071 kB`	`74.557 kB` `20.071 kB`	`4 B`
`react-table` Table (Sort only)	`73.16 kB` `19.671 kB`	`73.164 kB` `19.67 kB`	`4 B` `-1 B`
`react-tags-preview` InteractionTag	`14.271 kB` `5.717 kB`	`14.275 kB` `5.717 kB`	`4 B`
`react-tags-preview` Tag	`28.994 kB` `9.061 kB`	`28.998 kB` `9.061 kB`	`4 B`
`react-tags-preview` TagGroup	`72.503 kB` `21.606 kB`	`72.507 kB` `21.605 kB`	`4 B` `-1 B`
`react-text` Text - Default	`15.762 kB` `6.23 kB`	`15.766 kB` `6.23 kB`	`4 B`
`react-text` Text - Wrappers	`18.94 kB` `6.551 kB`	`18.944 kB` `6.551 kB`	`4 B`
`react-textarea` Textarea	`30.026 kB` `10.128 kB`	`30.03 kB` `10.129 kB`	`4 B` `1 B`
`react-toast` Toast (including Toaster)	`91.12 kB` `27.292 kB`	`91.124 kB` `27.293 kB`	`4 B` `1 B`
`react-tooltip` Tooltip	`50.855 kB` `17.956 kB`	`50.859 kB` `17.955 kB`	`4 B` `-1 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-jsx-runtime` Classic Pragma	`1.049 kB` `531 B`
`react-portal-compat` PortalCompatProvider	`6.48 kB` `2.203 kB`

_{🤖 This report was generated against 031ecaf9c383f81965aa5d057cd779f222a6d10a}

size-auditor · 2023-09-26T10:38:43Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 031ecaf9c383f81965aa5d057cd779f222a6d10a (build)

fabricteam · 2023-09-26T10:39:23Z

🕵 fluentuiv9 No visual regressions between this PR and main

bugfix: react dev runtime call is missing source parameter

70c7b39

bsunderhus self-assigned this Sep 26, 2023

github-actions bot added this to the September Project Cycle Q4 2023 milestone Sep 26, 2023

bsunderhus marked this pull request as ready for review September 26, 2023 10:21

bsunderhus requested a review from a team as a code owner September 26, 2023 10:21

bsunderhus changed the title ~~bugfix: react dev runtime call is missing source parameter~~ bugfix(react-jsx-runtime): react dev runtime call is missing source parameter Sep 26, 2023

layershifter approved these changes Sep 26, 2023

View reviewed changes

bsunderhus merged commit 3f90517 into microsoft:master Sep 26, 2023

bsunderhus deleted the react-jsx-runtime/bugfix--react-dev-runtime-call-missing-source branch September 26, 2023 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

bugfix(react-jsx-runtime): react dev runtime call is missing source parameter#29295

bugfix(react-jsx-runtime): react dev runtime call is missing source parameter#29295
bsunderhus merged 1 commit intomicrosoft:masterfrom
bsunderhus:react-jsx-runtime/bugfix--react-dev-runtime-call-missing-source

bsunderhus commented Sep 26, 2023 •

edited

Loading

Uh oh!

fabricteam commented Sep 26, 2023

Uh oh!

codesandbox-ci bot commented Sep 26, 2023

Uh oh!

fabricteam commented Sep 26, 2023

Uh oh!

size-auditor bot commented Sep 26, 2023

Uh oh!

fabricteam commented Sep 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

bsunderhus commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Sep 26, 2023

Perf Analysis (@fluentui/react-components)

Uh oh!

codesandbox-ci bot commented Sep 26, 2023

Uh oh!

fabricteam commented Sep 26, 2023

📊 Bundle size report

Uh oh!

size-auditor bot commented Sep 26, 2023

Asset size changes

Uh oh!

fabricteam commented Sep 26, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bsunderhus commented Sep 26, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)