bugfix(react-dialog): removes tabindex -1 from DialogSurface if not required#29340
Closed
bsunderhus wants to merge 1 commit intomicrosoft:masterfrom
Closed
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 72 | 10 | Possible regression |
| InfoButton | mount | 9 | 15 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 622 | 623 | 5000 | |
| Button | mount | 301 | 309 | 5000 | |
| Field | mount | 1107 | 1125 | 5000 | |
| FluentProvider | mount | 782 | 685 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 84 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 64 | 69 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 72 | 10 | Possible regression |
| InfoButton | mount | 9 | 15 | 5000 | Possible regression |
| MakeStyles | mount | 852 | 851 | 50000 | |
| Persona | mount | 1744 | 1688 | 5000 | |
| SpinButton | mount | 1376 | 1363 | 5000 |
bsunderhus
force-pushed
the
react-dialog/bugfix--removes-tabindex--1-from-surface-if-not-required
branch
from
a920811 to
a111556
Compare
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a111556:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b5f4971b4b04d5a02983ec472c4cc565ebd98d80 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
reviewed
Oct 2, 2023
| (dialog: HTMLElement | null) => { | ||
| if ( | ||
| dialog && | ||
| findFirstFocusable(dialog) === null && |
Contributor
There was a problem hiding this comment.
Do we need to fix this? We've only seen one case where this is an issue because users were using focus and blur events, and even that was worked around.
I propose moving this issue to the backlog and see if there are more standard use cases that are affected by the -1 tabindex on the DialogSurface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
DialogSurfaceby default hastabIndexset to-1, which is required for it to work properly on some edge cases #25150, but may cause some problems on some other #28404New Behavior
tabIndex=-1by defaultRelated Issue(s)