fix(web-components): remove empty text nodes from avatar #33963
+52
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
force-pushed
the
users/radium-v/wc-avatar-empty-slot
branch
from
d302e67 to
fe6f9b4
Compare
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Mar 10, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report
Accordion 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Accordion. - Dark Mode.normal.chromium_1.png | 2660 | Changed |
Avatar 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar.Active.normal.chromium.png | 97 | Changed |
| Avatar.Active Appearance.normal.chromium.png | 142 | Changed |
| Avatar. - Dark Mode.normal.chromium_1.png | 136 | Changed |
| Avatar.Size.normal.chromium.png | 953 | Changed |
Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Badge. - Dark Mode.normal.chromium.png | 511 | Changed |
Checkbox 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Checkbox. - Dark Mode.normal.chromium_1.png | 3 | Changed |
RadioGroup 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| RadioGroup. - Dark Mode.normal.chromium_1.png | 62 | Changed |
TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| TextInput. - Dark Mode.normal.chromium_1.png | 288 | Changed |
davatron5000
approved these changes
Mar 14, 2025
radium-v
force-pushed
the
users/radium-v/wc-avatar-empty-slot
branch
from
fe6f9b4 to
c1be15b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-web-components/Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Avatar. - Dark Mode.normal.chromium_1.png | 298 | Changed |
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 443 | Changed |
vr-tests-web-components/MenuList 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - Dark Mode.normal.chromium.png | 498 | Changed |
| vr-tests-web-components/MenuList. - RTL.2nd selected.chromium_3.png | 38816 | Changed |
| vr-tests-web-components/MenuList. - RTL.1st selected.chromium_2.png | 39384 | Changed |
| vr-tests-web-components/MenuList. - RTL.normal.chromium_1.png | 39083 | Changed |
vr-tests-web-components/RadioGroup 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/RadioGroup. - Dark Mode.normal.chromium_1.png | 89 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
radium-v
force-pushed
the
users/radium-v/wc-avatar-empty-slot
branch
2 times, most recently
from
9ec0f88 to
e714367
Compare
chrisdholt
approved these changes
Apr 15, 2025
marchbox
approved these changes
Apr 15, 2025
| if (!this.innerText.trim()) { | ||
| this.defaultSlot.assignedNodes().forEach(node => { | ||
| if (node.nodeType === Node.TEXT_NODE) { | ||
| (node as Element).remove(); |
Contributor
There was a problem hiding this comment.
Does editing the slot inside the slotchange event cause the slotchange event to fire again?
2 tasks
eljefe223
approved these changes
Jan 8, 2026
radium-v
force-pushed
the
users/radium-v/wc-avatar-empty-slot
branch
from
c487441 to
8495182
Compare
radium-v
commented
Jan 8, 2026
| if (!this.innerText.trim()) { | ||
| this.defaultSlot.assignedNodes().forEach(node => { | ||
| if (node.nodeType === Node.TEXT_NODE) { | ||
| (node as Element).remove(); |
Comment on lines
+31
to
+36
| test('should render an icon when no name or initials are provided', async ({ fastPage }) => { | ||
| const { element } = fastPage; | ||
| const icon = element.locator('svg'); | ||
|
|
||
| await expect(icon).toBeVisible(); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
This test doesn't handle the scenario where the slotted content is only blank content
Contributor
|
@radium-v, @chrisdholt, @eljefe223 what is needed to get this into an updated web components release? (rc 2?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
<fluent-avatar>web component displays as empty when blank content is present in the default slot. This causes the default fallback icon to disappear when there's no text content to display.New Behavior
This PR adds a routine on
slotchangeevents that removes purely empty text nodes from the default slot. This only happens if there is no slottedinnerTextin the component.