Skip to content

feat(eslint-plugin-react-components): add dynamic imports support to prefer-fluentui-v9 rule #34711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmytrokirpa wants to merge 10 commits into
base: master
Choose a base branch
from
+336 −35
Open

feat(eslint-plugin-react-components): add dynamic imports support to prefer-fluentui-v9 rule #34711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5a9029b
feat(eslint-plugin-react-components): add dynamic imports support to …
dmytrokirpa Jun 24, 2025
e5a9921
change
dmytrokirpa Jun 24, 2025
748d0bf
Merge branch 'master' into feat/eslint-plugin-prefere-fluentui-v9/dyn…
dmytrokirpa Jun 24, 2025
9a6da26
Merge branch 'master' into feat/eslint-plugin-prefere-fluentui-v9/dyn…
dmytrokirpa Jun 25, 2025
3b19596
address review comments
dmytrokirpa Jan 6, 2026
17139c2
Merge branch 'master' into feat/eslint-plugin-prefere-fluentui-v9/dyn…
dmytrokirpa Jan 6, 2026
bcdb753
fix lint issues
dmytrokirpa Jan 6, 2026
a0cbe8a
Merge branch 'master' into feat/eslint-plugin-prefere-fluentui-v9/dyn…
dmytrokirpa Jan 7, 2026
7984400
fixup after rebase
dmytrokirpa Jan 7, 2026
15b3875
Merge branch 'master' into feat/eslint-plugin-prefere-fluentui-v9/dyn…
dmytrokirpa Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-eslint-plugin-react-components-e047da88-e2eb-4e37-bdfe-aa555f9988b6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "feat: add dynamic imports support to prefer-fluentui-v9 rule",
"packageName": "@fluentui/eslint-plugin-react-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
69 changes: 69 additions & 0 deletions ...ages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,21 @@ ruleTester.run(RULE_NAME, rule, {
{
code: `import { Button } from '@fluentui/react-components';`,
},
{
code: `import { Dialog } from '@fluentui/react-components';`,
},
{
code: `import { DatePicker } from '@fluentui/react-datepicker-compat';`,
},
{
code: `import { Calendar } from '@fluentui/react-calendar-compat';`,
},
{
code: `const Calendar = React.lazy(() => import('@fluentui/react-calendar-compat').then(m => ({ default: m.Calendar })));`,
},
{
code: `const Dialog = React.lazy(async () => { const m = await import('@fluentui/react-components'); return { default: m.Dialog }; });`,
},
],
invalid: [
{
Expand All @@ -36,6 +51,60 @@ ruleTester.run(RULE_NAME, rule, {
},
],
},
{
code: `const Calendar = React.lazy(() => import('@fluentui/react').then(m => ({ default: m.Calendar })));`,
Copy link
Contributor

@Hotell Hotell Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this catch also standard dynamic imports outside React.lazy() ?

contrived example:

function hello(){
 import('@fluentui/react').then(m => ( 
window.v8 = m
console.log('react loaded') )
}

Copy link
Contributor Author

@dmytrokirpa dmytrokirpa Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test for this below

https://github.com/microsoft/fluentui/pull/34711/changes#diff-acfa21dee80b2642bb3443d9bd9f2a05fa1ba1cdd4898145cd2b4ede6d4a80f3R91

errors: [
{
messageId: 'replaceFluent8With9',
data: { fluent8: 'Calendar', fluent9: 'Calendar', package: '@fluentui/react-calendar-compat' },
},
],
},
{
code: `const Calendar = React.lazy(() => import('@fluentui/react').then(({ Calendar }) => ({ default: Calendar })));`,
errors: [
{
messageId: 'replaceFluent8With9',
data: { fluent8: 'Calendar', fluent9: 'Calendar', package: '@fluentui/react-calendar-compat' },
},
],
},
{
code: `const Dialog = React.lazy(async () => { const m = await import('@fluentui/react'); return { default: m.Dialog }; });`,
errors: [
{
messageId: 'replaceFluent8With9',
data: { fluent8: 'Dialog', fluent9: 'Dialog', package: '@fluentui/react-components' },
},
],
},
{
code: `const Dialog = React.lazy(async () => { const { Dialog } = await import('@fluentui/react'); return { default: Dialog }; });`,
errors: [
{
messageId: 'replaceFluent8With9',
data: { fluent8: 'Dialog', fluent9: 'Dialog', package: '@fluentui/react-components' },
},
],
},
{
code: `function hello() { import('@fluentui/react').then(m => { window.v8 = m.Button; console.log('react loaded'); }); }`,
errors: [
{
messageId: 'replaceFluent8With9',
data: { fluent8: 'Button', fluent9: 'Button', package: '@fluentui/react-components' },
},
],
},
{
code: `async function loadComponent() { const m = await import('@fluentui/react'); return m.Calendar; }`,
errors: [
{
messageId: 'replaceFluent8With9',
data: { fluent8: 'Calendar', fluent9: 'Calendar', package: '@fluentui/react-calendar-compat' },
},
],
},
{
code: `import { CompoundButton } from '@fluentui/react/lib/Button';`,
errors: [
Expand Down
Loading