-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore/react portal 19 attempt3 #34869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
layershifter
wants to merge
7
commits into
microsoft:master
Choose a base branch
from
layershifter:chore/react-portal-19-attempt3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore/react portal 19 attempt3 #34869
layershifter
wants to merge
7
commits into
microsoft:master
from
layershifter:chore/react-portal-19-attempt3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Pull request demo site: URL |
@@ -1,6 +1,7 @@ | |||
import * as React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png | 3 | Changed |
vr-tests-react-components/Charts-DonutChart 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 27053 | Changed |
vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 12635 | Changed |
vr-tests-react-components/Drawer 3 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Drawer.overlay drawer full.chromium.png | 6934 | Changed |
vr-tests-react-components/Drawer.overlay drawer full - Dark Mode.chromium.png | 3776 | Changed |
vr-tests-react-components/Drawer.overlay drawer full - RTL.chromium.png | 1145 | Changed |
vr-tests-react-components/Positioning 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Positioning.Positioning end.chromium.png | 499 | Changed |
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 711 | Changed |
vr-tests-react-components/Skeleton converged 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Skeleton converged.Opaque Skeleton with square - Dark Mode.default.chromium.png | 3 | Changed |
vr-tests-react-components/TagPicker 4 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 659 | Changed |
vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1321 | Changed |
vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 678 | Changed |
vr-tests-web-components/Accordion 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/Accordion. - Dark Mode.normal.chromium_1.png | 3151 | Changed |
vr-tests-web-components/Badge 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 444 | Changed |
vr-tests-web-components/MenuList 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/MenuList. - RTL.2nd selected.chromium.png | 17 | Changed |
vr-tests-web-components/TextInput 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/TextInput. - Dark Mode.normal.chromium_1.png | 286 | Changed |
vr-tests/Callout 8 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/Callout.Beak 25.default.chromium.png | 2185 | Changed |
vr-tests/Callout.Bottom right edge - RTL.default.chromium.png | 1114 | Changed |
vr-tests/Callout.Bottom left edge - RTL.default.chromium.png | 2186 | Changed |
vr-tests/Callout.Bottom right edge.default.chromium.png | 1120 | Changed |
vr-tests/Callout.Left center.default.chromium.png | 2544 | Changed |
vr-tests/Callout.Right bottom edge.default.chromium.png | 3037 | Changed |
vr-tests/Callout.No beak.default.chromium.png | 2177 | Changed |
vr-tests/Callout.No callout width specified.default.chromium.png | 2126 | Changed |
vr-tests/Keytip 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/Keytip.Offset.default.chromium.png | 86 | Changed |
vr-tests/react-charting-GaugeChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/react-charting-GaugeChart.Basic.default.chromium.png | 2 | Changed |
vr-tests/react-charting-LineChart 3 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/react-charting-LineChart.Events.default.chromium.png | 1 | Changed |
vr-tests/react-charting-LineChart.Multiple.default.chromium.png | 192 | Changed |
vr-tests/react-charting-LineChart.Multiple - RTL.default.chromium.png | 200 | Changed |
vr-tests/react-charting-VerticalBarChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png | 3 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)