Skip to content

fix(carousel): Add rounded corners and elevation using theme tokens #34971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+19 −2
Open

fix(carousel): Add rounded corners and elevation using theme tokens #34971

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7562d3
feat: enhance carousel styles with theme tokens follow desing guidence
Aug 5, 2025
e5a091a
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-carousel-a7426f68-6e99-4c35-8751-b8a3c86f5ce0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link

@github-actions github-actions bot Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Drawer 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Drawer.overlay drawer full - Dark Mode.chromium.png 2686 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 602 Changed
vr-tests-react-components/Positioning.Positioning end.chromium.png 728 Changed
vr-tests-react-components/TagPicker 3 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png 1321 Changed
vr-tests-react-components/TagPicker.disabled - RTL.chromium.png 635 Changed
vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png 678 Changed

There were 3 duplicate changes discarded. Check the build logs for more information.

"type": "patch",
"comment": "feat/enhance-carousel-styles-theme-tokens",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz put proper text describing the change there as it will appear in changelogs

"packageName": "@fluentui/react-carousel",
"email": "[email protected]",
"dependentChangeType": "patch"
}
3 changes: 3 additions & 0 deletions ...act-components/react-carousel/library/src/components/Carousel/useCarouselStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { makeStyles, mergeClasses } from '@griffel/react';
import type { SlotClassNames } from '@fluentui/react-utilities';
import { tokens } from '@fluentui/react-theme';

import type { CarouselSlots, CarouselState } from './Carousel.types';

Expand All @@ -16,6 +17,8 @@ const useStyles = makeStyles({
overflowX: 'hidden',
overflowAnchor: 'none',
position: 'relative',
margin: tokens.spacingVerticalL,
padding: tokens.spacingVerticalL,
},
});

Expand Down
3 changes: 3 additions & 0 deletions ...onents/react-carousel/library/src/components/CarouselCard/useCarouselCardStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { makeStyles, mergeClasses } from '@griffel/react';
import type { SlotClassNames } from '@fluentui/react-utilities';
import type { CarouselCardSlots, CarouselCardState } from './CarouselCard.types';
import { tokens } from '@fluentui/react-theme';

export const carouselCardClassNames: SlotClassNames<CarouselCardSlots> = {
root: 'fui-CarouselCard',
Expand All @@ -13,6 +14,8 @@ const useStyles = makeStyles({
root: {
flex: '0 0 100%',
maxWidth: '100%',
borderRadius: tokens.borderRadiusXLarge,
boxShadow: tokens.shadow16,
},
autoSize: {
flex: '0 0 auto' /* Adapt slide size to its content */,
Expand Down
2 changes: 2 additions & 0 deletions ...ts/react-carousel/library/src/components/CarouselSlider/useCarouselSliderStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { makeStyles, mergeClasses } from '@griffel/react';
import type { SlotClassNames } from '@fluentui/react-utilities';
import { tokens } from '@fluentui/react-theme';

import type { CarouselSliderSlots, CarouselSliderState } from './CarouselSlider.types';

Expand All @@ -14,6 +15,7 @@ const useStyles = makeStyles({
root: {
display: 'flex',
overflowAnchor: 'none',
gap: tokens.spacingHorizontalXXL,
},
});

Expand Down
6 changes: 4 additions & 2 deletions packages/react-components/react-carousel/stories/src/Carousel/CarouselDefault.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@ import * as React from 'react';
const useClasses = makeStyles({
bannerCard: {
alignContent: 'center',
borderRadius: tokens.borderRadiusLarge,
height: '450px',
textAlign: 'left',
position: 'relative',
},
image: {
borderRadius: 'inherit',
},
cardContainer: {
display: 'flex',
flexDirection: 'column',
Expand Down Expand Up @@ -55,7 +57,7 @@ const BannerCard: React.FC<{ children: React.ReactNode; imageSrc: string; index:

return (
<CarouselCard className={classes.bannerCard} aria-label={`${index + 1} of ${IMAGES.length}`} id={`test-${index}`}>
<Image fit="cover" src={imageSrc} role="presentation" />
<Image fit="cover" src={imageSrc} className={classes.image} role="presentation" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://react.fluentui.dev/?path=/docs/components-text--docs#presets

Should it be <Image shape="rounded" /> instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, I would discuss it with design team.
The logic here is that CarouselCard defines its own border radius style (tokens.borderRadiusXLarge = 8px) based on the latest design spec. The card controls its visual shape, and any inner content like Image/Card should inherit that. That way, the container enforces the design spec consistently, and content doesn’t override it with mismatched values (like shape="rounded", which would fall back to 4px).
This follows the “best practice” of letting the parent component define shape and having children adapt to it.

Open for any approach which design team will accept.


<div className={classes.cardContainer}>
<div className={classes.title}>{children}</div>
Expand Down
Loading