feat(react-utilities): enhance useFirstMount hook to support React concurrent mode with useEffect for first mount tracking #34985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ncurrent mode with setEffect for first mount tracking
dmytrokirpa
force-pushed
the
tests/react19-integration-e2e-tests-fix
branch
from
17259ee to
8fb7f0e
Compare
dmytrokirpa
changed the title
dmytrokirpa
changed the title
layershifter
approved these changes
Aug 7, 2025
…of realPress for better compatibility
dmytrokirpa
commented
Aug 8, 2025
| @@ -203,9 +204,9 @@ describe('FlatTree', () => { | |||
| </TreeTest>, | |||
| ); | |||
| cy.focused().should('not.exist'); | |||
| cy.document().realPress('Tab'); | |||
There was a problem hiding this comment.
realPress supports React 17 and 18, but not 19.
press is compatible with React 18 and 19.
So, I use press and provide a fallback for press in Cypress 13, since it is not available there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
useFirstMounthook did not fully support React's concurrent mode, which led to timing issues with first mount tracking and caused the React 19 e2e integration tests to fail.New Behavior
useFirstMounthook to properly support React concurrent mode usinguseEffectfor first mount trackingRelated Issue(s)