[feat: react-charts]: Donut annotations in V9 #35610
Open
+2,176
−877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
AtishayMsft
reviewed
Dec 30, 2025
|
|
||
| const padding = context.viewportPadding; | ||
| const paddingLeft = | ||
| typeof padding?.left === 'number' && Number.isFinite(padding.left) && padding.left > 0 ? padding.left : 0; |
AtishayMsft
reviewed
Dec 30, 2025
| ? context.plotRect | ||
| : undefined; | ||
|
|
||
| const clampX = clampRect && typeof clampRect.x === 'number' && Number.isFinite(clampRect.x) ? clampRect.x : 0; |
Contributor
There was a problem hiding this comment.
clampX clampY both values are very similar and repeating part of the code. See how we can reduce common code.
srmukher
force-pushed
the
users/srmukher/v9_donut_anno
branch
3 times, most recently
from
75c16d7 to
a63a35d
Compare
srmukher
force-pushed
the
users/srmukher/v9_donut_anno
branch
from
a63a35d to
0a02ca0
Compare
…ers/srmukher/v9_donut_anno
srmukher
force-pushed
the
users/srmukher/v9_donut_anno
branch
from
0b97f45 to
3b7be6e
Compare
AtishayMsft
reviewed
Jan 8, 2026
| return React.useMemo<UseDonutAnnotationLayoutResult>(() => { | ||
| const annotationList = annotations ?? EMPTY_ANNOTATIONS; | ||
| const layout = resolveDonutViewportLayout(annotationList, width, height, hideLabels); | ||
| const fallbackSvgWidth = typeof width === 'number' && Number.isFinite(width) ? Math.max(width, 0) : 0; |
Contributor
There was a problem hiding this comment.
Is any of the code in this file sharable with chart annotation layer.
AtishayMsft
reviewed
Jan 8, 2026
| const desiredWidth = Math.max(resolvedSvgWidth + totalHorizontalPadding, 0); | ||
| const desiredHeight = Math.max(resolvedSvgHeight + totalVerticalPadding, 0); | ||
|
|
||
| if (typeof width === 'number' && Number.isFinite(width)) { |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.