Added Garnet.Worker to win-x64-based-readytorun #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Service" folder. This required changes to the publishing file as well as create binaries powershell. NOTE - external release pipeline has the final release steps DISABLED so actual release doesn't happen when testing. However, testing code to only run the final push if on main
…et.Worker) doesn't get skipped.
…ipeline and not local. Maybe case sensitive issue with name.
badrishc
approved these changes
Mar 12, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release pipeline to support the inclusion of Garnet.Worker in the win-x64-based-readytorun.zip and adds an additional safeguard so that the final push to NuGet and GitHub releases only occurs from the main branch.
- Updated comments to clarify branch conditions for running release tasks.
- Added conditions to the GitHubRelease and NuGet push tasks to restrict execution to the main branch.
- Introduced a top-level pool definition and a job-specific pool definition with a specified vmImage.
Comments suppressed due to low confidence (1)
.azure/pipelines/azure-pipelines-external-release.yml:2
- Fix the phrase 'a the GitHub Release' to a correct phrasing, such as 'to generate the GitHub Release'.
# NOTE: Before running this pipeline to generate a the GitHub Release and new nuget packages, update the VersionPrefix value in Version.props file
…'t do it that way.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from a customer to add Garnet.Worker to the win-x64-based-readytorun.zip file. The main change was to the win-x64-based-readytorun.pubxml where I added the Garnet.Worker files to the "Service" folder.
The other change was to the release pipeline but that was mainly to put a check there that the actual push to Nuget and GitHub releases can only happen on Main. Can run everything else on another branch, but the final push can only happen on main. Just an extra safe guard that non main branches aren't being released.
The binaries ps1 file was specific to Garnet.Server (extra checks to double check Garnet.Server) so just small modification there