Remove unnecessary unsafe from GetGeoHashCode #1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulusParssinen
force-pushed
the
remove-unnecessary-unsafe-from-getgeohashcode
branch
from
adc25e6 to
80a445a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the GetGeoHashCode method by removing unnecessary unsafe code patterns. The refactoring replaces MemoryMarshal.GetReference combined with Unsafe.Add pointer arithmetic with straightforward array indexing. According to the godbolt analysis linked in the PR description, the compiler generates equivalent assembly code for both approaches, making the unsafe approach unnecessary.
Key Changes
- Replaced unsafe pointer-based character access with direct array indexing
- Simplified variable naming (
hashState→hash) for improved clarity - Removed unused
System.Runtime.InteropServicesimport
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Good find! |
badrishc
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this was unnecessary. https://godbolt.org/z/86jszKEY1