Skip to content

[Docs] Add Copilot skill for implementing new built-in RESP commands#1637

Merged
badrishc merged 8 commits intodevfrom
badrishc/garnet-command-skill
Mar 24, 2026
Merged

[Docs] Add Copilot skill for implementing new built-in RESP commands#1637
badrishc merged 8 commits intodevfrom
badrishc/garnet-command-skill

Conversation

@badrishc
Copy link
Copy Markdown
Collaborator

@badrishc badrishc commented Mar 17, 2026

Description of Change

Adds a new Copilot skill definition (.github/skills/add-garnet-command/SKILL.md)
that provides step-by-step guidance for implementing new built-in RESP commands in
Garnet. The skill covers:

  • RespCommand enum registration and ordering rules
  • Command parsing (fast path vs slow path)
  • Dispatch, RESP handler, API surface, and storage session wiring
  • RMW/Read callback implementation
  • Command metadata JSON generation via CommandInfoUpdater
  • ACL test requirements and integration test patterns
  • Common caveats (dot-prefixed commands, VarLenInputMethods, NeedCopyUpdate, etc.)

This is a documentation-only change — no runtime code is modified.

Copilot AI review requested due to automatic review settings March 17, 2026 23:18
@badrishc badrishc changed the title skill [Docs] Add Copilot skill for implementing new built-in RESP commands Mar 17, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub “skill” document that serves as an end-to-end checklist/guide for implementing a new built-in Garnet RESP command (from enum registration through parsing/dispatch, storage plumbing, metadata generation, ACL coverage, and integration tests).

Changes:

  • Introduces a new .github/skills/add-garnet-command/SKILL.md guide describing all required code touchpoints for adding a built-in RESP command.
  • Documents key caveats around parsing paths, dispatch placement (latency tracking), generated command metadata JSON, and ACL/integration testing expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@badrishc badrishc requested a review from TalZaccai March 17, 2026 23:47
Copy link
Copy Markdown
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, still reading

Copy link
Copy Markdown
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more comments

Copy link
Copy Markdown
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more comments

@badrishc badrishc merged commit 44da71b into dev Mar 24, 2026
44 of 45 checks passed
@badrishc badrishc deleted the badrishc/garnet-command-skill branch March 24, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants