updates deps 23 jul 2025 #450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it into update_deps_22_apr_2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies across the project, with the primary focus on upgrading Vert.x from version 4.5.14 to 5.0.1 and updating various Maven plugins and tools.
- Updated Vert.x from 4.5.14 to 5.0.1, requiring API migration from callback-based to Future-based patterns
- Updated Maven plugins and dependencies including JUnit, Checkstyle, and various Maven plugins
- Refactored Vert.x callback handlers to use the newer onComplete() pattern with AsyncResult
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vertx/pom.xml | Updated Vert.x core dependency from 4.5.14 to 5.0.1 |
| pom.xml | Updated Maven plugin versions and dependency versions |
| .mvn/wrapper/maven-wrapper.properties | Updated Maven wrapper to version 3.9.11 |
| VertxJVMEventChannel.java | Migrated deployVerticle callback to Future-based onComplete pattern |
| VertxDataSourceChannel.java | Migrated deployVerticle callback to Future-based onComplete pattern |
| VertxChannel.java | Migrated close callback to Future-based pattern and changed log level |
| JVMEventVerticle.java | Updated completionHandler to completion().onComplete() and removed auto-undeploy logic |
| DataSourceVerticle.java | Updated completionHandler to completion().onComplete() and removed auto-undeploy logic |
vertx/src/main/java/com/microsoft/gctoolkit/vertx/VertxChannel.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: Copilot <[email protected]>
|
@dsgrieve - Thought you might like that the pesky closing verticles during tests was finally fixable with vert.x 5 :-) |
…kit into updates_deps_23_jul_2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.