Skip to content

Comments

mlkem: initial implementation#119

Merged
gdams merged 9 commits intomainfrom
dev/gadams/mlkem
Nov 20, 2025
Merged

mlkem: initial implementation#119
gdams merged 9 commits intomainfrom
dev/gadams/mlkem

Conversation

@gdams
Copy link
Member

@gdams gdams commented Nov 19, 2025

fixes: #112

Proof that this works on a supported Windows system:

go test .\cng\ -run TestMLKEM -v
FIPS enabled: false
=== RUN   TestMLKEMRoundTrip
=== RUN   TestMLKEMRoundTrip/768
=== RUN   TestMLKEMRoundTrip/1024
--- PASS: TestMLKEMRoundTrip (0.00s)
    --- PASS: TestMLKEMRoundTrip/768 (0.00s)
    --- PASS: TestMLKEMRoundTrip/1024 (0.00s)
=== RUN   TestMLKEMBadLengths
=== RUN   TestMLKEMBadLengths/768
=== RUN   TestMLKEMBadLengths/1024
--- PASS: TestMLKEMBadLengths (0.01s)
    --- PASS: TestMLKEMBadLengths/768 (0.00s)
    --- PASS: TestMLKEMBadLengths/1024 (0.00s)
=== RUN   TestMLKEMConstantSizes
--- PASS: TestMLKEMConstantSizes (0.00s)
=== RUN   TestMLKEMInteropWithStdlib
=== RUN   TestMLKEMInteropWithStdlib/768_CNG_to_Stdlib
=== RUN   TestMLKEMInteropWithStdlib/768_Stdlib_to_CNG
=== RUN   TestMLKEMInteropWithStdlib/768_Bidirectional
=== RUN   TestMLKEMInteropWithStdlib/1024_CNG_to_Stdlib
=== RUN   TestMLKEMInteropWithStdlib/1024_Stdlib_to_CNG
=== RUN   TestMLKEMInteropWithStdlib/1024_Bidirectional
--- PASS: TestMLKEMInteropWithStdlib (0.00s)
    --- PASS: TestMLKEMInteropWithStdlib/768_CNG_to_Stdlib (0.00s)
    --- PASS: TestMLKEMInteropWithStdlib/768_Stdlib_to_CNG (0.00s)
    --- PASS: TestMLKEMInteropWithStdlib/768_Bidirectional (0.00s)
    --- PASS: TestMLKEMInteropWithStdlib/1024_CNG_to_Stdlib (0.00s)
    --- PASS: TestMLKEMInteropWithStdlib/1024_Stdlib_to_CNG (0.00s)
    --- PASS: TestMLKEMInteropWithStdlib/1024_Bidirectional (0.00s)
PASS
ok      github.com/microsoft/go-crypto-winnative/cng    (cached)

@gdams gdams marked this pull request as ready for review November 19, 2025 15:38
@gdams gdams requested a review from qmuntal November 19, 2025 15:39
@gdams gdams requested a review from qmuntal November 19, 2025 15:51
@gdams gdams requested a review from qmuntal November 19, 2025 22:32
gdams and others added 2 commits November 20, 2025 09:11
Co-authored-by: Quim Muntal <qmuntaldiaz@microsoft.com>
@gdams gdams requested a review from qmuntal November 20, 2025 09:17
@gdams gdams requested a review from qmuntal November 20, 2025 09:32
Copy link
Member

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to Go!

@gdams gdams merged commit 63d23e5 into main Nov 20, 2025
27 checks passed
@gdams gdams deleted the dev/gadams/mlkem branch November 20, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support crypto/mlkem

2 participants