Add tests for confirming struct and oneshot hashes are not allocating#91
Merged
Add tests for confirming struct and oneshot hashes are not allocating#91
Conversation
mertakman
changed the title
dagood
approved these changes
Apr 28, 2025
Member
dagood
left a comment
dagood
left a comment
There was a problem hiding this comment.
Definitely better to have these than nothing, but I do have a question.
| sink ^= cng.SHA1(msg)[0] | ||
| sink ^= cng.SHA256(msg)[0] | ||
| sink ^= cng.SHA384(msg)[0] | ||
| sink ^= cng.SHA512(msg)[0] |
Member
There was a problem hiding this comment.
Does it help in some way to put all of these in the same test?
Or could these be separate tests (perhaps using t.Run) to make it easier to figure out what went wrong when something changes?
Contributor
Author
There was a problem hiding this comment.
Good recommendation. We have so many tests with this approach so I actually used the same code for most of the tests, I'll see if we can cut any lines or make it look simpler with that approach on the other repositories too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for confirming struct and oneshot hashes are not allocating, also removed 1.22.x from test matrix and added 1.24.x.