Skip to content

Fix path in security policyenginesimulator sample #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmaxvl merged 1 commit into from
Dec 5, 2024
Merged

Fix path in security policyenginesimulator sample #2329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/tools/policyenginesimulator/samples/simple_framework/commands.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"feed": "contoso.azurecr.io/infra",
"issuer": "did:web:contoso.com",
"namespace": "fragment",
"local_path": "relative/path/to/local/fragment.rego"
Copy link
Contributor

@anmaxvl anmaxvl Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need to change? Is this not supposed to be a relative path?

Copy link
Member Author

@MahatiC MahatiC Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmaxvl It needs to change, because it fails when you try to run it. The custom policy one does work as it points to the right path.

I'd expect the example in here to work. Custom policy works as it points to the correct file (https://github.com/microsoft/hcsshim/blob/main/internal/tools/policyenginesimulator/samples/simple_custom/commands.json#L8)

Am I missing any reasoning to keep it this way even though it fails when you run it? This wrong path seems to be serving no purpose?

Copy link
Contributor

@anmaxvl anmaxvl Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was treating this as an example and not necessarily an actual path that should be used, but I don't feel strongly about it either.

"local_path": "fragment.rego"
}
},
{
Expand Down