[0035] Small update to clarify dimension requirements #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just removes the comment about being tied to wave size since the hardware sizes do not match wave sizes.
llvm-beanz
changed the title
llvm-beanz
changed the title
hekota
approved these changes
Nov 18, 2025
|
As I recall, wasn't there also a concern that the power of 2 limitation on K may also not map well to hardware? Multiples of a granularity might be a better limit; although unclear if that detail belongs here or elsewhere. (I'm looking at the table just below this change.) |
Collaborator
Author
Right! I'll just provide the range of valid values. |
spall
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just removes the comment about being tied to wave size since the hardware sizes do not match wave sizes.