fix(workflows): decouple SBOM artifact name from internal filename#1178
Merged
WilliamBerryiii merged 1 commit intomainfrom Mar 23, 2026
Merged
fix(workflows): decouple SBOM artifact name from internal filename#1178WilliamBerryiii merged 1 commit intomainfrom
WilliamBerryiii merged 1 commit intomainfrom
Conversation
- disable anchore/sbom-action built-in upload in generate-dependency-sbom - add explicit actions/upload-artifact step to preserve spdx.json filename - apply identical fix to both stable and prerelease workflows 🔧 - Generated by Copilot
katriendg
approved these changes
Mar 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
- Coverage 86.90% 86.89% -0.02%
==========================================
Files 59 59
Lines 8774 8774
==========================================
- Hits 7625 7624 -1
- Misses 1149 1150 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Dependency Review SummaryThe full dependency review summary was too large to display here (1555KB, limit is 1024KB). Please download the artifact named "dependency-review-summary" to view the complete report. |
rezatnoMsirhC
approved these changes
Mar 23, 2026
This was referenced Mar 23, 2026
WilliamBerryiii
pushed a commit
that referenced
this pull request
Mar 23, 2026
🤖 I have created a release *beep* *boop* --- ## [3.2.2](hve-core-v3.2.1...hve-core-v3.2.2) (2026-03-23) ### 🐛 Bug Fixes * **workflows:** decouple SBOM artifact name from internal filename ([#1178](#1178)) ([c3f1ef4](c3f1ef4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: hve-core-release-please[bot] <254602402+hve-core-release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the SBOM Dependency Diff failure in the stable and prerelease release pipelines.
anchore/sbom-actionusesartifact-nameas both the GitHub Actions artifact name and the filename inside the artifact. Withartifact-name: sbom-dependencies, the file stored inside the artifact was namedsbom-dependencies(no extension) instead ofdependencies.spdx.json. Downstream jobs (sbom-diff,attest-and-upload) download the artifact and look fordependencies.spdx.json— file not found.Fix: Disable
sbom-action's built-in upload (upload-artifact: false), add an explicitactions/upload-artifactstep that uploads the correctly-named local filedependencies.spdx.jsonas artifactsbom-dependencies. Applied identically to bothrelease-stable.ymlandrelease-prerelease.yml.Related Issue(s)
Fixes the v3.2.1 release failure in PR #1166, run #85.
Type of Change
.instructions.md).prompt.md).agent.md)SKILL.md)Testing
actionlint— no errors in either workflow file.npm run lint:yaml— no YAML lint errors.attest-and-uploadmatrix entries +sbom-diff).Checklist
Required Checks
Required Automated Checks
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run validate:skillsnpm run lint:md-linksnpm run lint:psnpm run plugin:generateSecurity Considerations
No new dependencies introduced. Workflow permissions unchanged. The explicit
upload-artifactstep uses the same SHA-pinned action already present elsewhere in the pipeline.Additional Notes
The per-VSIX SBOM uploads (e.g.,
sbom-ado,sbom-hve-core-all) are unaffected because no downstream job downloads those artifacts by filename.