fix: The if condition of __is_report_prompt should be more precise to prevent bash error prompts after each command.#330
Merged
cpendery merged 2 commits intomicrosoft:mainfrom May 21, 2025
GeekerHWH:main
Merged
fix: The if condition of __is_report_prompt should be more precise to prevent bash error prompts after each command.#330cpendery merged 2 commits intomicrosoft:mainfrom GeekerHWH:main
cpendery merged 2 commits intomicrosoft:mainfrom
GeekerHWH:main
Conversation
…nt bash error prompts after each command.
cpendery
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[fix]: The if condition of __is_report_prompt should be more precise to prevent bash error prompts after each command.
The ${parameter@P} syntax was first introduced in Bash 4.4, as showed in bash/CHANGES. Although the code checks for Bash version >= 4, it does not specify the minor version number. This causes Bash under 4.4 to report an error after each command is executed when using Inshellisense on an older stable platform such as CentOS7.
for example, my bash version is unfortunately v4.2.x, then bash warns every time I type a command and press Enter...

To Reproduce error
fixing is very simple, The if condition should be more precise, then everything is all right : )