Skip to content

Conversation

@GeekerHWH
Copy link
Contributor

@GeekerHWH GeekerHWH commented Mar 8, 2025

[fix]: The if condition of __is_report_prompt should be more precise to prevent bash error prompts after each command.

The ${parameter@P} syntax was first introduced in Bash 4.4, as showed in bash/CHANGES. Although the code checks for Bash version >= 4, it does not specify the minor version number. This causes Bash under 4.4 to report an error after each command is executed when using Inshellisense on an older stable platform such as CentOS7.

for example, my bash version is unfortunately v4.2.x, then bash warns every time I type a command and press Enter...
image

To Reproduce error

  • use bash (4.0 <= version < 4.4)
  • the latest Inshellisense

fixing is very simple, The if condition should be more precise, then everything is all right : )

@GeekerHWH GeekerHWH changed the title [fix]: The if condition of __is_report_prompt is more precise to prevent bash error prompts after each command. [fix]: The if condition of __is_report_prompt should be more precise to prevent bash error prompts after each command. Mar 8, 2025
@cpendery cpendery changed the title [fix]: The if condition of __is_report_prompt should be more precise to prevent bash error prompts after each command. fix: The if condition of __is_report_prompt should be more precise to prevent bash error prompts after each command. May 21, 2025
@cpendery cpendery merged commit dfdbdbc into microsoft:main May 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants