Skip to content

fix: empty suggestions block history scrolling #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpendery merged 2 commits into from
Jul 20, 2025
Merged

fix: empty suggestions block history scrolling #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adf34d1
fix: empty suggestions block history scrolling
cpendery Jun 28, 2025
00ed14c
fix: snapshot
cpendery Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/runtime/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ export const getSuggestions = async (cmd: string, cwd: string, shell: Shell): Pr
}
const result = await runSubcommand(activeCmd.slice(1), subcommand, resolvedCwd, shell);
if (result == null) return;
if (result.suggestions.length == 0 && !result.argumentDescription) return;

const charactersToDrop = lastCommand?.complete ? 0 : lastCommand?.tokenLength;
return { ...result, charactersToDrop };
Expand Down
14 changes: 2 additions & 12 deletions src/tests/runtime/__snapshots__/runtime.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,12 +293,7 @@ exports[`parseCommand completedOptionWithArg 1`] = `
}
`;

exports[`parseCommand emptySuggestions 1`] = `
{
"charactersToDrop": 2,
"suggestions": [],
}
`;
exports[`parseCommand emptySuggestions 1`] = `undefined`;

exports[`parseCommand exclusiveOnOption 1`] = `
{
Expand Down Expand Up @@ -528,12 +523,7 @@ exports[`parseCommand noArgsArgumentGiven 1`] = `
}
`;

exports[`parseCommand noOptionsSuggestedDuringVariadicArg 1`] = `
{
"charactersToDrop": 3,
"suggestions": [],
}
`;
exports[`parseCommand noOptionsSuggestedDuringVariadicArg 1`] = `undefined`;

exports[`parseCommand optionsSuggestedAfterVariadicArg 1`] = `
{
Expand Down
Loading