feat: include node information in upsert command response #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add node ID to the JSON response of the upsert (put) command to inform users which node was used for the operation.
Changes:
- Modified UpsertCommand to include node.Id in response output
- Response now shows: {id, node, completed, queued, error}
- All 301 tests pass with 81.99% coverage
🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)
Co-Authored-By: Amplifier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the upsert (put) command to include node information in the JSON response, allowing users to see which node was used for the operation.
Before:
{ "id": "sh7lxf0xxkyekj70632czg2c", "completed": true, "queued": false }After:
{ "id": "sh7lxf0xxkyekj70632czg2c", "node": "personal", "completed": true, "queued": false }Changes
UpsertCommand.csto includenode.Idin response outputInitialize()methodTesting
Stats
Breaking Changes
None - this is a backward-compatible enhancement that adds information to the response.