Skip to content

Conversation

@dluc
Copy link
Collaborator

@dluc dluc commented Dec 2, 2025

Summary

Address consistency issues identified during project review.

Changes

  • Pre-commit hook: Added .git/hooks/pre-commit that runs format.sh and build.sh before commits (per AGENTS.md requirement)
  • clean.sh: Now includes Main.Tests bin/obj/TestResults cleanup
  • km.sh: Fixed shebang to use portable /usr/bin/env bash
  • KNOWN-ISSUES.md: Documented 2 configuration limitations (hardcoded index ID and index weights)

Test plan

  • All 520 tests pass (306 Core + 214 Main)
  • Zero skipped tests
  • Code coverage at 83.82% (above 80% threshold)
  • build.sh passes with 0 warnings
  • format.sh passes
  • coverage.sh passes
  • Pre-commit hook runs successfully on commit

Note

The pre-commit hook is created in .git/hooks/ which is not tracked by git. New clones will need to set up the hook.

- Add pre-commit hook that runs format.sh and build.sh
- Update clean.sh to include Main.Tests cleanup
- Add km.sh portable shebang (/usr/bin/env bash)
- Document known configuration limitations in KNOWN-ISSUES.md
@dluc dluc force-pushed the consistency-fixes branch from 06a7ee0 to 6408386 Compare December 2, 2025 11:26
@dluc dluc merged commit 2ebdbe4 into main Dec 2, 2025
7 checks passed
@dluc dluc deleted the consistency-fixes branch December 2, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants