fix: make index ID configurable in NodeSearchService #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Index ID is no longer hardcoded as "fts-main". It can now be passed as a constructor parameter with backward-compatible default. Changes: - Add DefaultFtsIndexId constant to SearchConstants - Add indexId parameter to NodeSearchService constructor - Add 4 unit tests for index ID configuration - Remove issue #4 from KNOWN-ISSUES.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes known issue 4: Index ID was hardcoded as
"fts-main"instead of being configurable.Changes
src/Core/Search/SearchConstants.cs: AddedDefaultFtsIndexIdconstantsrc/Core/Search/NodeSearchService.cs: AddedindexIdconstructor parameter with default value for backward compatibilitytests/Core.Tests/Search/NodeSearchServiceIndexIdTests.cs: Added 4 unit testsKNOWN-ISSUES.md: Removed resolved issue 4Test plan
build.shpasses with 0 warningsformat.shpassescoverage.shpassesBackward Compatibility
Fully backward compatible - the constructor parameter has a default value matching the previous hardcoded behavior.