fix: make index weights configurable in SearchService #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Index weights for reranking can now be configured per-index instead of using hardcoded defaults. Weights are read from SearchIndexConfig.Weight property in the node configuration. Changes: - Add indexWeights parameter to SearchService constructor - Extract weights from NodeConfig.SearchIndexes in SearchCommand - Add 6 unit tests for index weight configuration - Remove known issue "Index Weights Not Configurable" from KNOWN-ISSUES.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the known issue "Index Weights Not Configurable" - index weights for reranking can now be configured per-index instead of using hardcoded defaults.
Changes
src/Core/Search/SearchService.cs: AddedindexWeightsconstructor parameter, updatedBuildRerankingConfigto use configured weightssrc/Main/CLI/Commands/SearchCommand.cs: Extract weights fromNodeConfig.SearchIndexesand pass toSearchServicetests/Core.Tests/Search/SearchServiceIndexWeightsTests.cs: 6 new unit testsKNOWN-ISSUES.md: Removed the resolved issueConfiguration Example
Users can now configure index weights in
~/.km/config.json:{ "nodes": { "personal": { "searchIndexes": [ { "id": "sqlite-fts", "type": "sqliteFTS", "weight": 0.7 }, { "id": "vector-main", "type": "sqliteVector", "weight": 0.3 } ] } } }Test plan
build.shpasses with 0 warningsformat.shpassescoverage.shpassesBackward Compatibility
Fully backward compatible - missing weights default to
SearchConstants.DefaultIndexWeight(1.0).