Fix Max Upload Size handling #893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dluc
reviewed
Nov 15, 2024
|
|
||
| /// <summary> | ||
| /// The maximum allowed size in megabytes for a request body posted to the upload endpoint. | ||
| /// The maximum allowed size in bytes for a request body posted to the upload endpoint. |
Collaborator
There was a problem hiding this comment.
as per conversation, I'd prefer sticking to "megabytes"
dluc
reviewed
Nov 15, 2024
| { | ||
| if (this.MaxUploadSizeMb.HasValue) | ||
| { | ||
| return Math.Min(10, this.MaxUploadSizeMb.Value) * 1024 * 1024; |
Collaborator
There was a problem hiding this comment.
I think this is the only line that needs fixing, using Math.Max. I'd keep also the min of 10Mb in place.
Contributor
Author
There was a problem hiding this comment.
So don't you want to handle scenarios where, for example, I need to limit the upload to 1 MB?
Contributor
Author
|
I think that this PR has been superseded by #896, so it can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context (Why the change? What's the scenario?)
See #863 (comment) and the comments below