Update the OPTEE shim to use CrngProvider#504
Merged
jstarks merged 2 commits intomicrosoft:mainfrom Nov 19, 2025
Merged
Conversation
The OPTEE shim should use the new provider to generate random bytes--I missed this in my previous PR. As part of this, fix the shim's handling of large RNG requests to match OPTEE OS (failing above 4096 bytes). Also, add the fake RNG implementation to the LVBS kernel, to be replaced later.
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
sangho2
approved these changes
Nov 19, 2025
Contributor
sangho2
left a comment
sangho2
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OPTEE shim should use the new provider to generate random bytes--I missed this in my previous PR. As part of this, fix the shim's handling of large RNG requests to match OPTEE OS (failing above 4096 bytes).
Also, add the fake RNG implementation to the LVBS kernel, to be replaced later.