Skip to content

Comments

LVBS: Use VP index and separate CPU entry points#676

Open
sangho2 wants to merge 1 commit intomainfrom
sanghle/lvbs/vpindex
Open

LVBS: Use VP index and separate CPU entry points#676
sangho2 wants to merge 1 commit intomainfrom
sanghle/lvbs/vpindex

Conversation

@sangho2
Copy link
Contributor

@sangho2 sangho2 commented Feb 20, 2026

This PR make LVBS use VP index instead of CPUID-based APIC ID and
separate CPU entry points for BSP and APs.

@github-actions
Copy link

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_missing.ron

Failed in:
  function litebox_platform_lvbs::arch::get_core_id, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/c39d3556b2aebc020466a3ec879a05a86a3c0848/litebox_platform_lvbs/src/arch/x86/mod.rs:24

Comment on lines +146 to +152
// TODO: The cpumask provides Linux CPU IDs which may not match Hyper-V VP indices.
// Currently we assume cpu_id == vp_index, which holds for standard Hyper-V topologies
// but is not architecturally guaranteed. Two possible fixes:
// 1) Have VTL0 pass per-CPU hv_vp_index values so VTL1 can translate
// Linux CPU IDs to Hyper-V VP indices.
// 2) Have VTL0 compute and pass an online VP-index mask (instead of a
// conventional cpumask) so VTL1 can use VP indices directly.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #677

@sangho2 sangho2 marked this pull request as ready for review February 20, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant