Skip to content

fix: sanitize uploaded filenames to prevent path traversal #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
husseinmozannar merged 2 commits into from
Feb 12, 2026
+7 −0
Merged

fix: sanitize uploaded filenames to prevent path traversal #488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e05d2f4
fix: sanitize uploaded filenames to prevent path traversal
cheng-tan Feb 12, 2026
ee37879
Merge branch 'main' into fix/path-traversal-upload
cheng-tan Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/magentic_ui/backend/web/routes/runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# /api/runs routes
import os
from typing import Dict, List
from datetime import datetime

Expand Down Expand Up @@ -128,6 +129,12 @@ async def upload_files(
logger.error(f"Error getting filename: {e}")
continue

# Sanitize filename: strip directory components to prevent path traversal attacks
filename = os.path.basename(filename)
if not filename:
logger.error("Empty filename after sanitization, skipping file")
continue

file_path = paths.internal_run_dir / filename

# Ensure the directory exists
Expand Down
Loading