-
Notifications
You must be signed in to change notification settings - Fork 294
Add test to verify fonts export to SVG without arc commands #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
14
commits into
master
Choose a base branch
from
copilot/add-font-test-no-arcs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: danmarshall <[email protected]>
Co-authored-by: danmarshall <[email protected]>
Co-authored-by: danmarshall <[email protected]>
Co-authored-by: danmarshall <[email protected]>
Co-authored-by: danmarshall <[email protected]>
Co-authored-by: danmarshall <[email protected]>
Co-authored-by: danmarshall <[email protected]>
Co-authored-by: danmarshall <[email protected]>
Copilot
AI
changed the title
[WIP] Add test to ensure no arcs in SVG output
Add test to verify fonts export to SVG without arc commands
Dec 29, 2025
Contributor
|
@copilot undo your commits to these files: |
Co-authored-by: danmarshall <[email protected]>
Contributor
Author
Contributor
|
@copilot nice work. can we do more characters than just 'A' |
Co-authored-by: danmarshall <[email protected]>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates that font text models convert BezierCurve arcs back to BezierSeeds during SVG export, ensuring no arc (A) commands appear in the output.
Changes
textFromFontNoArcsInSVG()validating ArbutusSlab-Regular and NewRocker-Regular fonts export without arc commands using "Hello World" test string to validate multiple character shapes.github/copilot-instructions.mddocumenting build artifacts and lockfiles that should never be committed (but not gitignored)Test Coverage
The test creates text models with "Hello World" and validates:
The test confirms BezierCurves generated from fonts are properly unified back to BezierSeeds (Q/C commands) rather than remaining as approximating arcs during SVG export, validating across diverse character shapes including uppercase, lowercase, and letters with various curves.
Testing
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.