Skip to content

Ensure safe ExifTool usage: require >= 12.24 #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afourney merged 3 commits into from
Aug 26, 2025
Merged

Ensure safe ExifTool usage: require >= 12.24 #1399

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d524138
feat: add version verification for ExifTool to ensure security compli…
Aug 16, 2025
8ed3c34
fix: improve ExifTool version verification
Aug 16, 2025
1907af6
Merge branch 'main' into main
afourney Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/markitdown/src/markitdown/converters/_exiftool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,23 @@ def exiftool_metadata(
if not exiftool_path:
return {}

# Verify exiftool version
try:
version_output = subprocess.run(
[exiftool_path, "-ver"],
capture_output=True,
text=True,
check=True,
).stdout.strip()
version = float(version_output)
if version < 12.24:
raise RuntimeError(
f"ExifTool version {version} is vulnerable to CVE-2021-22204. "
Comment thread
t3tra-dev marked this conversation as resolved.
Outdated
"Please upgrade to version 12.24 or later."
)
except (subprocess.CalledProcessError, ValueError) as e:
raise RuntimeError("Failed to verify ExifTool version.") from e
Comment thread
t3tra-dev marked this conversation as resolved.

# Run exiftool
cur_pos = file_stream.tell()
try:
Expand Down