fix: send browser user-agent for HTTP URI conversions#1849
Open
jaythehardcoder wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: send browser user-agent for HTTP URI conversions#1849jaythehardcoder wants to merge 1 commit intomicrosoft:mainfrom
jaythehardcoder wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-Agentheader for HTTP/HTTPS URI conversionsProblem
Issue #1467 reports URL conversions failing against endpoints that reject requests without a browser-style
User-Agent, even though the same URLs work in a normal browser.Fix
MarkItDown now includes a browser-like
User-Agentheader on its HTTP fetch path before passing the response through the normal conversion flow.Test Plan
python3 -m pytest -q packages/markitdown/tests/test_module_misc.py -k http_uri_uses_browser_user_agentpython3 -m pytest -q packages/markitdown/tests/test_module_misc.pyCloses #1467