Skip generating md links in 'pre' blocks#322
Merged
afourney merged 1 commit intomicrosoft:mainfrom Feb 11, 2025
Merged
Conversation
Member
|
Nice find. Thanks for the PR. We should add a test for this to avoid regressing. But it's simple enough that we can add tests in another PR. |
t-kalinowski
added a commit
to tidyverse/ragnar
that referenced
this pull request
Feb 16, 2025
- contains fix for `pre` microsoft/markitdown#322 - DocumentConverterResult moved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown does not support links in pre-formatted code blocks.
With the current release,
markitdownmangles code chunks by generating links.For example:
markitdown https://r4ds.hadley.nz/base-rwill generate code chunks that look like this:With this patch, the same code chunk is now correctly generated