Great Cancellation: Updating New-Command.md file to include#1768
Open
Great Cancellation: Updating New-Command.md file to include#1768
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request completes the "Great Cancellation" initiative (issue #1583) by adding cancellationToken parameters to methods where they were present but unused, and updating the new-command.md documentation to reflect proper cancellationToken usage patterns throughout Azure SDK method calls.
Changes:
- Added cancellationToken parameters to
CreateArmClientWithApiVersionAsyncandCreateOrUpdateGenericResourceAsyncin BaseAzureResourceService - Updated callers in Storage, Foundry, and Quota tools to pass cancellationToken through the call chain
- Enhanced documentation with comprehensive examples showing correct named parameter syntax for cancellationToken usage
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| core/Microsoft.Mcp.Core/src/Services/Azure/BaseAzureResourceService.cs | Added cancellationToken parameter to CreateArmClientWithApiVersionAsync and CreateOrUpdateGenericResourceAsync methods |
| tools/Azure.Mcp.Tools.Storage/src/Services/StorageService.cs | Updated CreateStorageAccount to pass cancellationToken to CreateArmClientWithApiVersionAsync and CreateOrUpdateGenericResourceAsync |
| tools/Azure.Mcp.Tools.Foundry/src/Services/FoundryService.cs | Updated DeployModel to pass cancellationToken to CreateArmClientWithApiVersionAsync and CreateOrUpdateGenericResourceAsync |
| tools/Azure.Mcp.Tools.Quota/src/Services/Util/AzureRegionChecker.cs | Added cancellationToken to GetModelsAsync and ExecuteLocationBasedCapabilitiesAsync calls |
| servers/Azure.Mcp.Server/docs/new-command.md | Updated documentation examples to consistently show cancellationToken usage with named parameter syntax |
alzimmermsft
approved these changes
Feb 19, 2026
Contributor
alzimmermsft
left a comment
There was a problem hiding this comment.
Looks good! Just fix the two comments by copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improved new-command doc to include cancellationToken in appropriate scenarios. Also added cancellationToken to methods where the parameter exists but was unused.
GitHub issue number?
#1583
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline