Skip to content

Great Cancellation: Updating New-Command.md file to include#1768

Open
msalaman wants to merge 3 commits intomainfrom
masalama/cancellationTokenFollowup
Open

Great Cancellation: Updating New-Command.md file to include#1768
msalaman wants to merge 3 commits intomainfrom
masalama/cancellationTokenFollowup

Conversation

@msalaman
Copy link
Contributor

What does this PR do?

Improved new-command doc to include cancellationToken in appropriate scenarios. Also added cancellationToken to methods where the parameter exists but was unused.

GitHub issue number?

#1583

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request completes the "Great Cancellation" initiative (issue #1583) by adding cancellationToken parameters to methods where they were present but unused, and updating the new-command.md documentation to reflect proper cancellationToken usage patterns throughout Azure SDK method calls.

Changes:

  • Added cancellationToken parameters to CreateArmClientWithApiVersionAsync and CreateOrUpdateGenericResourceAsync in BaseAzureResourceService
  • Updated callers in Storage, Foundry, and Quota tools to pass cancellationToken through the call chain
  • Enhanced documentation with comprehensive examples showing correct named parameter syntax for cancellationToken usage

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
core/Microsoft.Mcp.Core/src/Services/Azure/BaseAzureResourceService.cs Added cancellationToken parameter to CreateArmClientWithApiVersionAsync and CreateOrUpdateGenericResourceAsync methods
tools/Azure.Mcp.Tools.Storage/src/Services/StorageService.cs Updated CreateStorageAccount to pass cancellationToken to CreateArmClientWithApiVersionAsync and CreateOrUpdateGenericResourceAsync
tools/Azure.Mcp.Tools.Foundry/src/Services/FoundryService.cs Updated DeployModel to pass cancellationToken to CreateArmClientWithApiVersionAsync and CreateOrUpdateGenericResourceAsync
tools/Azure.Mcp.Tools.Quota/src/Services/Util/AzureRegionChecker.cs Added cancellationToken to GetModelsAsync and ExecuteLocationBasedCapabilitiesAsync calls
servers/Azure.Mcp.Server/docs/new-command.md Updated documentation examples to consistently show cancellationToken usage with named parameter syntax

Copy link
Contributor

@alzimmermsft alzimmermsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just fix the two comments by copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants

Comments