Merged
Conversation
Test Results 8 files ± 0 8 suites ±0 46s ⏱️ +8s Results for commit a314648. ± Comparison against base commit 270e12c. This pull request removes 6 and adds 13 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
bwittgen
reviewed
Jan 16, 2025
bwittgen
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling and testing of security descriptors and access control entries (ACEs). The most important changes include the modification of the
SDToStringfunction, the addition of new test data files, and the restructuring of the project to better organize the smart view components.Improvements to security descriptor handling:
UI/MySecInfo.cpp: ReplacedSDToStringwithNTSDToStringand simplified theDebugPrintoutput.Addition of new test data files:
UnitTest/SmartViewTestData/In/ACECONTAINER-1.dat,UnitTest/SmartViewTestData/In/ACEFB-1.dat,UnitTest/SmartViewTestData/In/ACEMESSAGE-1.dat,UnitTest/SmartViewTestData/In/ACEMESSAGE-2.dat,UnitTest/SmartViewTestData/In/ACL-1.dat,UnitTest/SmartViewTestData/In/NTSD-1.dat,UnitTest/SmartViewTestData/In/NTSD-5.dat,UnitTest/SmartViewTestData/In/SECURITYDESCRIPTOR-1.dat,UnitTest/SmartViewTestData/In/SID-6.dat,UnitTest/SmartViewTestData/In/SID-7.dat). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Project restructuring:
core/core.vcxproj: Moved security descriptor related headers and source files to a new directorysmartview/SDand updated project files accordingly. [1] [2] [3] [4]core/core.vcxproj.filters: Updated filters to reflect the new directory structure for SD components. [1] [2] [3] [4]Codebase simplification:
UnitTest/tests/sidtest.cpp: Removed redundantACEToStringandSDToStringtest methods and updatedTest_LookupAccountSidmethod. [1] [2] [3]core/interpret/sid.cpp: Included new headers forNTSDandSmartViewcomponents.These changes enhance the maintainability and clarity of the codebase, improve the organization of smart view components, and expand the test coverage for security descriptors and ACEs.