Merged
Conversation
bwittgen
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve code readability and simplify the parsing logic in the
smartviewnamespace. The changes primarily involve renaming variables to follow consistent naming conventions and refactoring the parsing logic for entry IDs.Improvements to code readability:
core/smartview/ConversationIndex.cpp: Renamed variables fromPropStringandAltPropStringtopropStringandaltPropStringfor consistency with naming conventions.Simplification of parsing logic:
core/smartview/ReportTag.cpp: Refactored the parsing logic to remove redundant code and simplify the handling of entry IDs by introducing size checks and conditional parsing.core/smartview/ReportTag.h: Included theEntryIdStructheader file and updated member variables to use consistent naming conventions and new parsing logic. Removed theaddEIDmethod as it is no longer needed. [1] [2]