Skip to content

Support -fno-exceptions when building with C++ support #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support -fno-exceptions when building with C++ support #572

wants to merge 4 commits into from

Conversation

@Jarred-Sumner
Copy link
Contributor

@Jarred-Sumner Jarred-Sumner commented Apr 5, 2022

Using abort to match what is done elsewhere

This reduces the number of symbols imported which can slightly improve startup time

Before:

❯ nm -g (which bun) | wc -c
19707

After:

❯ nm -g (which bun) | wc -c
19430

daanx
daanx reviewed Apr 8, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daanx daanx daanx left review comments

+1 more reviewer

@devnexen devnexen devnexen left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jarred-Sumner @daanx @devnexen