Skip to content

Update Go to 1.25 and CodeQL workflow #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madhanrm merged 7 commits into from
Jan 22, 2026
Merged

Update Go to 1.25 and CodeQL workflow #413

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
92582ab
Initial plan
Copilot Jan 21, 2026
988daaf
Update Go version to 1.25
Copilot Jan 21, 2026
d80aa2e
Remove go.sum and generate it dynamically via make targets
Copilot Jan 21, 2026
a21c316
Add tidy dependency to unittest target
Copilot Jan 21, 2026
0f46c52
Fix golangci-lint build error with Go 1.25
Copilot Jan 21, 2026
6bf258b
Retain go.sum in repository
Copilot Jan 22, 2026
5f212dd
Update CodeQL workflow to v3
Copilot Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,3 +331,6 @@ ASALocalRun/
.mfractor/

vendor/

# Go module files - go.sum is generated dynamically by make targets
go.sum
4 changes: 2 additions & 2 deletions .pipelines/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- task: GoTool@0
inputs:
version: '1.24.3'
version: '1.25.3'
- task: InstallSSHKey@0
inputs:
knownHostsEntry: '$(KNOWN_HOST)'
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
steps:
- task: GoTool@0
inputs:
version: '1.24.3'
version: '1.25.3'

- script: |
make golangci-lint
Expand Down
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export GO111MODULE=on
#
PKG :=

all: format test
all: tidy format test

.PHONY: tidy
tidy:
Expand All @@ -24,13 +24,13 @@ tidy:
format:
gofmt -s -w rpc/ pkg/

bootstrap:
bootstrap: tidy
GOOS="linux" go get -u google.golang.org/grpc@v1.59.0
GOOS="linux" go install github.com/golang/protobuf/protoc-gen-go@v1.3.2

test: unittest

unittest:
unittest: tidy
$(GOTEST) ./pkg/...

generate: bootstrap
Expand All @@ -47,7 +47,7 @@ ifeq ($(MOCKGEN),)
endif
MOCKGEN=$(shell command -v mockgen 2> /dev/null)

mocks:
mocks: tidy
go mod download github.com/golang/mock
go get github.com/golang/mock@v1.6.0
go generate ./...
Expand Down
12 changes: 5 additions & 7 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module github.com/microsoft/moc

go 1.24.0

toolchain go1.24.7
go 1.25.0

require (
github.com/go-logr/logr v1.4.3
Expand All @@ -14,7 +12,7 @@ require (
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.8.3
go.uber.org/multierr v1.11.0
google.golang.org/grpc v1.76.0
google.golang.org/grpc v1.59.0
gopkg.in/yaml.v3 v3.0.1
)

Expand All @@ -23,9 +21,9 @@ require (
github.com/pmezard/go-difflib v1.0.0 // indirect
golang.org/x/net v0.42.0 // indirect
golang.org/x/sys v0.34.0 // indirect
golang.org/x/text v0.31.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20251111163417-95abcf5c77ba // indirect
google.golang.org/protobuf v1.36.10 // indirect
golang.org/x/text v0.33.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20260120221211-b8f7ae30c516 // indirect
google.golang.org/protobuf v1.36.11 // indirect
)

replace (
Expand Down
98 changes: 0 additions & 98 deletions go.sum
View file
Open in desktop

This file was deleted.

Loading