docs: change var require to window.require#4751
Open
Blackman99 wants to merge 3 commits intomicrosoft:mainfrom
Open
docs: change var require to window.require#4751Blackman99 wants to merge 3 commits intomicrosoft:mainfrom
var require to window.require#4751Blackman99 wants to merge 3 commits intomicrosoft:mainfrom
Conversation
|
"In some" but not all of them. |
|
Good fix. Changing |
callmegautam
approved these changes
Jun 21, 2025
callmegautam
left a comment
There was a problem hiding this comment.
Looks good! Using window.require makes it globally accessible – avoids reference errors in some browser environments. Nice improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser script edtior sample use
var require = ...In some senario
varwould be auto replaced toconst(ESLint eg.). And would cause worker not found, so as other resource files.