Merged
Conversation
caiomcbr
reviewed
Mar 12, 2025
caiomcbr
reviewed
Mar 13, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancements to all-gather operation, a temporary solution to fix the memory overhead when integrating msccl++ with pytorch.
This solution will not register input/output buffer to msccl++, so the temp output buffer for allgather could be reused by torch automatically.
allgather8kernel function inapps/nccl/src/allgather.hppto handle larger data sizes more efficiently. This includes double buffering to hide synchronization overhead and support for both in-place and out-of-place operations.allgatherfunction to decide betweenallgather6andallgather8based on data size and platform, improving performance for large data sizes.Configuration and environment improvements:
MSCCLPP_DISABLE_CHANNEL_CACHEto control whether the channel cache is disabled, enhancing configurability. This variable is now part of theEnvclass and is logged during environment initialization.mscclppDisableChannelCachefromsrc/debug.ccand updated its usage to refer to the new environment variable.